So I've stopped beating myself up about making my schoolboy error not isolating the battery (I should know better!)
With a test light I found power to the starter motor and power from the starter button to the starter motor when it was pressed. I took the starter motor off and tried to get at the solenoid. I undid the screw that holds it to the casing and then tried to free it off with a few gentle taps with a hammer. Closer examination suggested that it may be a screw fit as there are slight flats either side, didn't have anything thin enough to fit, so gave up on that idea.
I decided to try Mattw 's test so refitted the starter and hooked it up. Lo and behold its now working as it should - maybe the hammer tapping freed up a slight short inside the solenoid?
Tried some old plugs in the bike that I knew were working and found that they were no better than the original set. Looks like it's back to replacing the Hall Effect Sensor.